What is the incorrect action and why does it occur?

Question

Specification: Ask the user for a character array and then reverse the characters. If the user entered Hello World, the new string would read dlroW olleH.
```
#include
using namespace std;
int main()
{
char saying[50],revSaying[50];
int i;
cout << ”\nEnter a saying.”;
cin.getline(saying,50);
for(i = 0; i< 50; ++i)
{
revSaying[i] = saying[50-i];
}
return 0;
}
```

Answer 1

A problem is that reversing action shown here will reverse all fifty characters. The leading characters in the revSaying will contain “trash” from the trailing portion of saying as well as the ‘\0’. If you tried to write the reversed C-string, you’d maybe see trash only.

To fix this, we should find the length of the input. This length is used to reverse just the valid characters in the string, like this:

```
int length = strlen(saying); // reports # of letters

for(i = 0; i < length; ++ i)
{
revSaying[i] = saying[ length – 1 - i ] ;
}
//then put a ‘\0’ at end of the revSaying
revSaying [ length – 1 ] = ‘\0’;
```